Skip to content

REL: 1.2.0 #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2019
Merged

REL: 1.2.0 #2930

merged 5 commits into from
May 9, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented May 8, 2019

Summary

Prep for 1.2.0 release, targeting Thursday, May 9. Shooting for a pretty short turnaround mostly because we overshot by about a month, but also because #2878 would be very useful to have in a published release.

If there's something you strongly want to see in 1.2.0, please add it to the 1.2.0 milestone or respond here ASAP. We can make a pre-release tomorrow morning for the sake of depending on it on PyPI, and extend the 1.2.0 window as needed.

Otherwise, please add it to the 1.2.1 milesteone. Note that I targeted that one to late June, as this next month is going to be busy.

Release checklist

  • Update changelog
  • Update .mailmap
  • Update .zenodo.json
  • Set release number in nipype/info.py and doc/conf.py
  • Update doc/documentation.rst with previous releases
  • Tutorial tests (@djarecka)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member Author

effigies commented May 8, 2019

Note that the following names don't have Zenodo entries. Please comment with your preferred info if you want to be listed as an author on Zenodo releases. Apologies if you've done this before and our script removed you. I'll update the mailmap to make sure it doesn't happen again. Please use any diacritics and initials that you would want in a publication. And if you don't have an ORCID, I would recommend getting one.

No entry to sort: John Lee (@leej3)
No entry to sort: Martin (@MartinPerez)
No entry to sort: Isaiah Norton (@ihnorton)
No entry to sort: Niklas Förster (@niklasfoe)
No entry to sort: daniel glen (@afni-dglen)
No entry to sort: Matt Cieslak (@mattcieslak)
No entry to sort: Kirstie Whitaker (@KirstieJane)
No entry to sort: hstojic (@hstojic)
No entry to sort: Gio Piantoni (@gpiantoni)
No entry to sort: Jonathan R. Williford (@williford)
No entry to sort: Hao (@anbai106)
No entry to sort: Fred Mertz
No entry to sort: Kevin Sitek (@sitek)
No entry to sort: Ami Tsuchida
No entry to sort: Abel González (@abelalez)
No entry to sort: Michiel Cottaar (@MichielCottaar)
No entry to sort: Michael R. Crusoe (@mr-c)
No entry to sort: Daniel Brenner (@brennerd11)
No entry to sort: BenjaminMey (@BenjaminMey)
No entry to sort: Andrew Van (@vanandrew)

I don't think Fred Mertz is a real name, and I can't quickly find an Ami Tsuchida on GitHub, but I think I've mapped everybody else to their GitHub users. If you don't want to be listed as an author, I'll add you to an exclude list so that I don't bother you again.

@codecov-io
Copy link

Codecov Report

Merging #2930 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2930      +/-   ##
==========================================
+ Coverage   67.59%   67.59%   +<.01%     
==========================================
  Files         344      344              
  Lines       43746    43747       +1     
  Branches     5456     5456              
==========================================
+ Hits        29568    29569       +1     
  Misses      13469    13469              
  Partials      709      709
Flag Coverage Δ
#smoketests 50.33% <100%> (-0.04%) ⬇️
#unittests 65.03% <100%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/info.py 89.55% <100%> (-4.39%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 67.5% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b871f...9044554. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #2930 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2930      +/-   ##
==========================================
+ Coverage   67.59%   67.59%   +<.01%     
==========================================
  Files         344      344              
  Lines       43746    43747       +1     
  Branches     5456     5456              
==========================================
+ Hits        29568    29569       +1     
  Misses      13469    13469              
  Partials      709      709
Flag Coverage Δ
#smoketests 50.33% <100%> (-0.04%) ⬇️
#unittests 65.03% <100%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/info.py 89.55% <100%> (-4.39%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 67.5% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b871f...8c315b9. Read the comment docs.

@mr-c
Copy link
Contributor

mr-c commented May 9, 2019

@effigies effigies merged commit a0f756d into master May 9, 2019
@leej3
Copy link
Contributor

leej3 commented May 9, 2019

Apologies for the delay. I got a zenodo account (leej3), and my orcid is https://orcid.org/0000-0001-5884-4247. John A Lee would be good. Thanks

@mattcieslak
Copy link
Contributor

Did I miss the window?

    {
      "name": "Cieslak, Matthew",
      "affiliation": "Department of Neuropsychiatry, University of Pennsylvania",
      "orcid": "0000-0002-1931-4734"
    }

@effigies
Copy link
Member Author

effigies commented May 9, 2019

Yeah, sorry about that. I'll get you both in so you'll be on the next release. Anybody else who wants to add themselves, feel free to comment.

@effigies effigies deleted the rel/1.2.0 branch May 9, 2019 15:15
@BenjaminMey
Copy link
Contributor

BenjaminMey commented May 9, 2019

Created a Zenodo account, following is my info:

{
"affiliation": "University of Pittsburgh",
"name": "Meyers, Benjamin",
"orcid": "0000-0001-9137-4363"
}

@vanandrew
Copy link
Contributor

My orchid link: https://orcid.org/0000-0002-8787-0943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants