ENH: enable/disable resource monitor in the fixture per test #2725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a more "kosher" way to avoid side-effects across tests etc. It was "inspired" to mitigate an issue of some stale processes being kept in background preventing pytest run completion, see nipy#2719 So, even though it avoids that issue now (both tests are skipped anyways unconditionally ATM), it does not solve it -- some issue causing that was introduced somewhere between 1.1.2 and 1.1.3
oesteban
approved these changes
Oct 10, 2018
|
not sure what is up with those circleci fails - seems unrelated, waiting on travis. Locally debian builds seems finally started to pass that hiccup |
|
Waiting on #2707. |
|
@yarikoptic Can you merge master? That may fix tests. |
* origin/master: FIX: Pin coverage<5 [FIX] Pin codecov to <5.0 so Travis is fixed
|
done |
|
Hoo boy, it sure didn't. |
|
well -- travis is green |
|
Codecov considers any failing tests as potentially missing information, and avoids posting incomplete coverage summaries. I'm okay with merging, as this is a necessary fix. We'll deal with the rest as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a more "kosher" way to avoid side-effects across tests etc.
It was "inspired" to mitigate an issue of some stale processes being
kept in background preventing pytest run completion, see
#2719
So, even though it avoids that issue now (both tests are skipped anyways
unconditionally ATM), it does not solve it -- some issue causing that
was introduced somewhere between 1.1.2 and 1.1.3