Skip to content

FIX: Copy FSCommand.version to ReconAll.version #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

effigies
Copy link
Member

Summary

Fixes #2655. See discussion there for justification.

List of changes proposed in this PR (pull-request)

  • Copy FSCommand.version to ReconAll.version

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies added this to the 1.1.1 milestone Jul 26, 2018
@effigies effigies requested a review from oesteban July 26, 2018 21:33
@oesteban
Copy link
Contributor

With this patch

>>> from nipype.interfaces.freesurfer import ReconAll
>>> ReconAll().version
'6.0.1'

-> merging in. Thanks!

@oesteban oesteban merged commit aeb0874 into nipy:master Jul 26, 2018
@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #2656 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
- Coverage   67.62%   67.62%   -0.01%     
==========================================
  Files         340      340              
  Lines       43050    43054       +4     
  Branches     5328     5329       +1     
==========================================
+ Hits        29114    29115       +1     
- Misses      13234    13237       +3     
  Partials      702      702
Flag Coverage Δ
#smoketests 50.51% <25%> (-0.01%) ⬇️
#unittests 65.09% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/freesurfer/preprocess.py 66.11% <25%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffe23d...6643a5f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FreeSurfer version returns None
4 participants