fixing unicode_literals issues #1638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me add FreeSurfer to the testing image, we could be missing something we are not currently testing. |
effigies
reviewed
Sep 15, 2016
| @@ -211,7 +211,7 @@ def __init__(self, **inputs): | |||
| def _num_threads_update(self): | |||
| if self.inputs.num_threads: | |||
| self.inputs.environ.update( | |||
| {'OMP_NUM_THREADS': str(self.inputs.num_threads)}) | |||
| {'OMP_NUM_THREADS': bytes(self.inputs.num_threads)}) | |||
There was a problem hiding this comment.
Python 2:
>>> bytes(5)
'5'Python 3:
>>> bytes(5)
b'\x00\x00\x00\x00\x00'I suspect what you want is:
>>> str(5).encode()
b'5'
Current coverage is 71.09% (diff: 100%)@@ master #1638 diff @@
==========================================
Files 1028 1030 +2
Lines 50616 51927 +1311
Methods 0 0
Messages 0 0
Branches 7333 7346 +13
==========================================
+ Hits 35994 36919 +925
- Misses 13495 13890 +395
+ Partials 1127 1118 -9
|
|
@bpinsard - can you check if current master fixes your issues? i cannot get this line to error using current master in either py27 or py35: |
|
@bpinsard - can you let us know if this still an issue with current master? |
|
@oesteban yes it seems that it is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1621
fixes my problems