TYPE: Annotate file-handling modules #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
type/filehandling
branch
from
ef06c65 to
fdd8c84
Compare
Codecov ReportBase: 92.16% // Head: 92.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
==========================================
- Coverage 92.16% 92.15% -0.01%
==========================================
Files 97 97
Lines 12332 12334 +2
Branches 2534 2534
==========================================
+ Hits 11366 11367 +1
Misses 645 645
- Partials 321 322 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
effigies
force-pushed
the
type/filehandling
branch
2 times, most recently
from
6811774 to
1fd1a44
Compare
ZviBaratz
approved these changes
Feb 18, 2023
effigies
force-pushed
the
type/filehandling
branch
from
0f2da16 to
e70123a
Compare
Opener proxy methods now match io.BufferedIOBase prototypes. Remove some version checks for indexed-gzip < 0.8, which supported Python 3.6 while our minimum is now 3.8. A runtime-checkable protocol for .read()/.write() was the easiest way to accommodate weird file-likes that aren't IOBases. When indexed-gzip is typed, we may need to adjust the output of _gzip_open.
effigies
force-pushed
the
type/filehandling
branch
from
e70123a to
b5c8f8e
Compare
effigies
force-pushed
the
type/filehandling
branch
from
b5c8f8e to
d13768f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR annotates the following modules:
filename_parser, which covers coercion ofos.PathLikes tostr, and detecting related files based on extensionsfileholders, which allows us to carry around filenames or open streams somewhat agnosticallyopeners, which allows us to read/write from filenames or open streams, and transparently enables compression