-
Notifications
You must be signed in to change notification settings - Fork 261
NF: Add zstd compression support #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add zstandard compression for analyze format images via pyzstd. - Add zstd option under setup.cfg options.extra_requires.
Hello @vanandrew, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2021-06-04 17:54:08 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 92.26% 92.26% -0.01%
==========================================
Files 100 100
Lines 12164 12201 +37
Branches 2128 2134 +6
==========================================
+ Hits 11223 11257 +34
- Misses 615 616 +1
- Partials 326 328 +2
Continue to review full report at Codecov.
|
- Fix code formatting issues - Remove unused imports - Fix undefined reference to ZstdFile when pyzstd missing
Thanks for this! Been a little burnt out, so trying to take it easy this week. If nobody does a proper review by next Monday, please feel free to @ me. |
@vanandrew Thanks for your patience. Overall this looks good, and I wanted to try my suggestions before sending you down the rabbit hole, so I ended up just submitting vanandrew#1. |
Almost forgot about this PR myself,,, Going on vacation starting next week, so I'll try to take a look at/merge vanandrew#1 this week before I leave. |
RF: Use optional_package to allow code to assume pyzstd is present
Your changes seem fine to me. I merged in vanandrew#1. |
Looks good. Thanks for the PR! |
Some stuff I was playing around with... This PR adds zstd compression/decompression support for the
Opener
class.zstd (Zstandard) is a relatively new compression library that boasts significant improvements in compression/decompression speeds over zlib with minimal differences in compression ratios.
Results from
bench_fileslice.py
withzst
added: