fix: various fixes left over from refactor #142
Conversation
mgxd
commented
Jan 30, 2018
mgxd
commented
- missing function imports
- moved some variables to their proper scope
- some pep8 fixes as well
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=========================================
- Coverage 80.11% 79.4% -0.72%
=========================================
Files 16 17 +1
Lines 1509 1534 +25
=========================================
+ Hits 1209 1218 +9
- Misses 300 316 +16
Continue to review full report at Codecov.
|
| # prov information | ||
| prov_file = prefix + '_prov.ttl' if with_prov else None | ||
| if prov_file: | ||
| safe_copyfile(op.join(convertnode.base_dir, |
There was a problem hiding this comment.
so we need a test which runs with prov -- this clause isn't covered
There was a problem hiding this comment.
yes, but currently i believe this option is broken with latest nipype (#108)
There was a problem hiding this comment.
so looks like prov <=1.5.0 is fine (nipy/nipype#2240), but we should complain if user's version is higher
There was a problem hiding this comment.
travis is probably fine/has an old one ;-)
