-
Notifications
You must be signed in to change notification settings - Fork 100
STY: Dont log info messages by default #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Argh this does not work, I'll probably just set them to |
+100 on this; I have |
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 74.94% 74.90% -0.04%
==========================================
Files 7 7
Lines 2594 2594
Branches 514 514
==========================================
- Hits 1944 1943 -1
- Misses 475 476 +1
Partials 175 175 |
Just changed all |
@@ -40,7 +40,11 @@ before_install: | |||
- pip install vtk | |||
- pip install mayavi | |||
- mkdir -p $SUBJECTS_DIR | |||
- pip install "https://api.github.com/repos/mne-tools/mne-python/zipball/master" | |||
- if [ "${PYTHON_VERSION}" == "3.5" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could drop 3.5 support? Most pydata packages have...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it in another PR. It would be good to do that while also adding 3.8 now that VTK9 is out. But that might require quite a few iterations...
When processing things in a loop I get spammed by a lot of:
I don't think this is very useful for users in general, so by default we probably shouldn't log it.