Skip to content

STY: Dont log info messages by default #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2020
Merged

Conversation

larsoner
Copy link
Contributor

When processing things in a loop I get spammed by a lot of:

colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)
colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)
colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)
colormap sequential: [0.00e+00, 9.68e-01, 1.94e+00] (transparent)

I don't think this is very useful for users in general, so by default we probably shouldn't log it.

@larsoner
Copy link
Contributor Author

Argh this does not work, I'll probably just set them to logger.debug instead of logger.info

@mwaskom
Copy link
Member

mwaskom commented May 15, 2020

+100 on this; I have verbose=0 set all over the place.

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #293 into master will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   74.94%   74.90%   -0.04%     
==========================================
  Files           7        7              
  Lines        2594     2594              
  Branches      514      514              
==========================================
- Hits         1944     1943       -1     
- Misses        475      476       +1     
  Partials      175      175              

@larsoner
Copy link
Contributor Author

Just changed all logger.info to logger.debug, then fixed an MNE install error

@@ -40,7 +40,11 @@ before_install:
- pip install vtk
- pip install mayavi
- mkdir -p $SUBJECTS_DIR
- pip install "https://api.github.com/repos/mne-tools/mne-python/zipball/master"
- if [ "${PYTHON_VERSION}" == "3.5" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could drop 3.5 support? Most pydata packages have...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in another PR. It would be good to do that while also adding 3.8 now that VTK9 is out. But that might require quite a few iterations...

@larsoner larsoner merged commit 1afce4b into nipy:master May 18, 2020
@larsoner larsoner deleted the verbose branch May 18, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants