MRG, FIX: Fix bug with scale_data_colormap #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 74.5% 74.83% +0.33%
==========================================
Files 7 7
Lines 2577 2583 +6
Branches 513 513
==========================================
+ Hits 1920 1933 +13
+ Misses 480 475 -5
+ Partials 177 175 -2 |
larsoner
commented
Feb 19, 2020
| @@ -12,4 +12,5 @@ filterwarnings = | |||
| ignore:.*ufunc size changed.*:RuntimeWarning | |||
| ignore:Using or importing the ABCs:DeprecationWarning | |||
| ignore:the imp module is deprecated in favour of importlib:DeprecationWarning | |||
| ignore:.*trait handler has been deprecated.*:DeprecationWarning | |||
There was a problem hiding this comment.
Upstream fix is in enthought/mayavi#896 waiting for merge
|
Also @mwaskom I think this was listed as the only (?) blocker for release, so if you're okay with it once this is merged I'll push a new version out |
|
I'm traveling for the next few days and won't have a chance to look closely but +1 on release and go ahead and merge if it resolves the issue. |
|
Okay, onward we go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #281
On
masterthe snippet from #281 gives:And on this PR:
@mwaskom feel free to look/test/merge if you're happy.