MRG: width/height in offscreen mode #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
========================================
+ Coverage 74.95% 75% +0.05%
========================================
Files 7 7
Lines 2511 2517 +6
Branches 505 506 +1
========================================
+ Hits 1882 1888 +6
Misses 454 454
Partials 175 175 |
larsoner
changed the title
|
Ready for review/merge from my end. This one is a pretty trivial fix aside from the necessary CI updating. I'll merge tomorrow probably assuming it comes back green unless someone wants more time to look. |
|
thx @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug from #245 that showed up when
w != has values ended up swapped.