[ENH] Use upstream TShift improvements #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we actually use slice timing in any of our tests, so we can't go by Circle on this... |
effigies
force-pushed
the
rf/upstream_tshift
branch
from
fd9e35b to
95b8130
Compare
effigies
force-pushed
the
rf/upstream_tshift
branch
from
95b8130 to
8a78c38
Compare
effigies
force-pushed
the
rf/upstream_tshift
branch
from
8a78c38 to
78b9c66
Compare
|
Status update: nipy/nipype#2608 will be in 1.1.1, so I'll update this and we can merge after 1.1.1. I tested on ds000030/sub-10159. Output files of the TShift step differed by timestamp. |
oesteban
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TShift.inputs.slice_timinginstead of helperFunctioninterface