Skip to content

Smarter test of multiecho datasets #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oesteban opened this issue Jun 5, 2020 · 3 comments · Fixed by #1803
Closed

Smarter test of multiecho datasets #2179

oesteban opened this issue Jun 5, 2020 · 3 comments · Fixed by #1803
Assignees
Milestone

Comments

@oesteban
Copy link
Member

oesteban commented Jun 5, 2020

Instead of:

https://github.com/poldracklab/fmriprep/blob/4c54ca4f855d4f560c7c4abdbbbcb4fb3a60bae6/fmriprep/workflows/bold/base.py#L147

we may want to do something like:

entities = layout.parse_file_entities(ensure_list(ref_file)[0])
multiecho = "echo" in entities

May I suggest to address this in the context of #1803 ?

@oesteban oesteban added the bug label Jun 5, 2020
@oesteban oesteban added this to the 20.2.0 LTS milestone Jun 5, 2020
@tsalo
Copy link
Collaborator

tsalo commented Jun 8, 2020

Sorry for the delay on responding to this. Is echo prohibited for single-echo data? The specification is unclear:

Multi-echo data MUST be split into one file per echo. Each file shares the same name with the exception of the _echo-<index> key/value.

If we assume that single-echo data cannot include echo, then I think the proposed check is good.

@tsalo tsalo added the me-epi label Jun 8, 2020
@oesteban
Copy link
Member Author

oesteban commented Jun 8, 2020

Perhaps this is easier than I thought in the beginning. What about testing:

multiecho = len(entities.pop("echo", [])) > 2

@oesteban
Copy link
Member Author

oesteban commented Jun 8, 2020

I believe that covers one of the edge cases of #2182 too.

oesteban added a commit to tsalo/fmriprep that referenced this issue Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants