Update installing-nginx-docker.md #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed gerunds from headings and also fixed capitalization.
github-actions
bot
added
documentation
|
Ashley, can you try again? As we talked about, we use sentence case in our titles. It's something we could do a better job publicizing: https://github.com/nginx/documentation/blob/main/templates/style-guide.md#titles-use-sentence-case |
mjang
requested changes
May 4, 2025
There was a problem hiding this comment.
Ashley, can you try again? As we talked about, we use sentence case in our titles. It's something we could do a better job publicizing: https://github.com/nginx/documentation/blob/main/templates/style-guide.md#titles-use-sentence-case
mjang
reviewed
May 4, 2025
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
…cker.md Agreed per our discussion! Co-authored-by: Mike Jang <[email protected]>
apgordon312
commented
May 4, 2025
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
apgordon312
commented
May 4, 2025
There was a problem hiding this comment.
@mjang Updates made! I was only able to commit the first change - everything else only allowed me to submit for review.
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
…cker.md Committing change from title case to sentence case.
|
@mjang Okay, I was able to commit each change after submitting the review. Back to you! |
…cker.md Committing change from title case to sentence case.
mjang
reviewed
May 5, 2025
content/nginx/admin-guide/installing-nginx/installing-nginx-docker.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed gerunds from headings and also fixed capitalization.