Skip to content

Update product titles and articles in one.json #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

4acf
Copy link
Contributor

@4acf 4acf commented Mar 2, 2025

Proposed changes

Problem: The phrases "NGINX One console" and "the NGINX One Console" in static/nginx-one/api/one.json don't conform to style updates.

Solution: Changed all instances of "NGINX One console" to "NGINX One Console" and removed the article "the" in front of any relevant instances.

Testing: N/A

Please focus on (optional): There are two more files with the specific phrase "NGINX One console", I can open separate PRs to fix both of those but I figured I would start with one.

If this PR addresses an issue on GitHub, ensure that you link to it here:

#228 (only addresses a small portion of the issue)

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@4acf 4acf requested a review from a team as a code owner March 2, 2025 01:51
Copy link

github-actions bot commented Mar 2, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@4acf
Copy link
Contributor Author

4acf commented Mar 2, 2025

I have hereby read the F5 CLA and agree to its terms

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: The phrases "NGINX One console" and "the NGINX One Console" in static/nginx-one/api/one.json don't conform to style updates.

Thank you! It's nice to know that people read our style guides!

Please focus on (optional): There are two more files with the specific phrase "NGINX One console", I can open separate PRs to fix both of those but I figured I would start with one.

I appreciate the way you're organizing the changes that you're making. I approve your contribution, and look forward to more!

@mjang mjang added the community label Mar 3, 2025
@mjang mjang merged commit 7263c52 into nginx:main Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants