Skip to content

Include process tag in the hoverover of HTML reports #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evanfloden opened this issue Nov 2, 2017 · 18 comments
Closed

Include process tag in the hoverover of HTML reports #504

evanfloden opened this issue Nov 2, 2017 · 18 comments
Labels

Comments

@evanfloden
Copy link
Member

When using the hover over feature of the graphs in HTML reports, the process id is shown.

See here.

This is redundant and it would be much more useful to see the task tag so you can see which task is using the specified resource.

So in the example above, instead of showing:

(default_alignment, 36.5)

it would be more informative to see

(task_specific_tag, 36.5)

pditommaso added a commit that referenced this issue Jan 24, 2018
This commit adds a new `summary` data object in the JSON 
payload embedded in the HTML execution report. This 
needs to be used to visualise the execution metrics 
charts, instead to compute them on client side which 
can be overkill for workflow executing a large number 
of tasks. 


Issues: #547, #504
@pditommaso pditommaso added this to the v0.28.0 milestone Feb 16, 2018
@pditommaso
Copy link
Member

@ewels I need the help of the report guru :) Any chance to see if it's possible to customise the boxplot hover label with the ones provided by NF?

@ewels
Copy link
Member

ewels commented Feb 26, 2018

Nope, I'm afraid that this isn't possible. The hover text is for the boxplot (not the dots next to the box plot), and the median doesn't have a task specific tag that we can show. In other words, we're not pointing the to task that's using 36.5, we're pointing to the box plot maximum.

From memory, there was some way to get a tooltip on the dots instead of the box plot, which does then show more useful information. But off the top of my head I can't remember how sorry.

@pditommaso
Copy link
Member

I see, so I'm postponing this issue to a future release in which we may use a different chart library.

@pditommaso pditommaso removed this from the v0.28.0 milestone Feb 26, 2018
@ewels
Copy link
Member

ewels commented Feb 26, 2018

Maybe I'm wrong - possible that a fairly recent update has addressed this: plotly/plotly.js#192 (comment)

@pditommaso
Copy link
Member

Actually I've updated to the latest Plotty version, but I was unable to control the box text display.

@ewels
Copy link
Member

ewels commented Feb 26, 2018

It should be in the JS library from v1.32 onwards: https://github.com/plotly/plotly.js/releases/tag/v1.32.0 (PR was here: plotly/plotly.js#2094)

@pditommaso
Copy link
Member

In the master we are using plotly.js v1.34.0.

@ewels
Copy link
Member

ewels commented Feb 26, 2018

Hmm, then you should be able to set the hoveron: 'points' property in that case. How did it not work? Just ignored?

@pditommaso
Copy link
Member

Frankly, I don't remember the tests I've done.

@ewels
Copy link
Member

ewels commented Feb 26, 2018

Super speedy whitespace refactor and addition of the hoveron line here: master...ewels:boxplot_hover

Completely untested at this point, so no idea if it works ;)

@pditommaso
Copy link
Member

Nice, I will give a try asap

@pditommaso
Copy link
Member

Nope, not working :/

@ewels
Copy link
Member

ewels commented Mar 1, 2018

If there aren't any points now, then it won't.. ;) It enables tooltips on the points themselves, not the boxplot.

@pditommaso
Copy link
Member

pditommaso commented Mar 1, 2018

Wait, there are points. It gets an array [min, q1, q1, median, q3, q3, max].

@ewels
Copy link
Member

ewels commented Mar 1, 2018

yeah, but not in the plot, to the side of the boxplot I mean.

@pditommaso
Copy link
Member

I see. I was thinking it was possible to have in place of labels showed over min,q1,etc.

@ewels
Copy link
Member

ewels commented Mar 1, 2018

Nope, that's not possible. Those values are not task data points, they're distributions of a process. So they can't be labelled with the names of data points, only the process name.

@stale
Copy link

stale bot commented Apr 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 27, 2020
@pditommaso pditommaso added stale and removed wontfix labels Apr 27, 2020
@stale stale bot closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants