Skip to content

fix americas test kitchen import "tool" prop parsing #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saywebsolutions
Copy link
Contributor

Topic and Scope

Fix 2523 - allow recipes to imported from americastestkitchen.com.

Concerns/issues

Some additional improvements may also be helpful on the frontend in order to display the tool prop when it's an array.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Copy link

github-actions bot commented Mar 9, 2025

Test Results

   12 files    588 suites   1m 56s ⏱️
  577 tests   577 ✅ 0 💤 0 ❌
2 308 runs  2 307 ✅ 1 💤 0 ❌

Results for commit 845e134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

America's Test Kitchen, failes to parse json due to "tool" list
1 participant