Fix pool connection ownership #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
fix-pool-connection-ownership
branch
from
847a144 to
7d9a95d
Compare
robsdedude
force-pushed
the
fix-pool-connection-ownership
branch
from
7d9a95d to
bb06487
Compare
robsdedude
force-pushed
the
fix-pool-connection-ownership
branch
2 times, most recently
from
70e899b to
91292a9
Compare
Fixes `ValueError: deque.remove(x): x not in deque` when multiple connections to the same server brake more or less simultaneously.
robsdedude
force-pushed
the
fix-pool-connection-ownership
branch
from
91292a9 to
b695e56
Compare
AndyHeap-NeoTech
approved these changes
Jun 1, 2022
robsdedude
added a commit
that referenced
this pull request
Jun 1, 2022
…-4.4 [4.4] Fix pool connection ownership 4.4 Backport or #732 Fixing and testing two faulty corner-cases * When a connection fails, all idle connections to that host will be closed. If their closure fails, the same action is invoked recursively while being in the process of closing idle connections already. This leads to inconsistent data. * [4.4 only] When opening of a new connection fails, the pool used to forcefully close all connections to the host, including lent connections. Opening the doors wide for race conditions because connections are not thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing and testing two faulty corner-cases
If their closure fails, the same action is invoked recursively while being
in the process of closing idle connections already. This leads to
inconsistent data.
forcefully close all connections to the host, including lent
connections. Opening the doors wide for race conditions because connections
are not thread safe.