Fix bookmark comparison #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bookmarks need to be parsed and compared in order to send the most up-to-date bookmark to an old-ish Neo4j version. Previous versions do not support multiple bookmarks in metadata. They only support a single one. This commit fixes a problem with bookmark parsing for further comparison. Bookmark format consists of a fixed prefix and an int identifier. Previous parser assumed that they are colon-separated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookmarks need to be parsed and compared in order to send the most up-to-date bookmark to an old-ish Neo4j version. Previous versions do not support multiple bookmarks in metadata. They only support a single one.
This PR fixes a problem with bookmark parsing for further comparison. Bookmark format consists of a fixed prefix and an int identifier. Previous parser assumed that they are colon-separated.
Resolves #249