Skip to content

Add prepend filters method #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2019
Merged

Add prepend filters method #131

merged 2 commits into from
May 4, 2019

Conversation

fink3l
Copy link
Contributor

@fink3l fink3l commented Feb 20, 2019

The pull request helps in situations when you collect part of the filters statically and some need to be collected dynamically and with a higher priority.

Copy link
Collaborator

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There is some minor changes to do but looks good to me otherwise

- Remove unnecessary phpdoc
- Switch leading backslash array_unshift to use function
- Fix for 2.x version
- Add unit test
@theofidry theofidry merged commit 86776fc into myclabs:2.x May 4, 2019
@theofidry
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants