fix(stablediffusion): Avoid overwriting SYCL specific flags from outer make call #5181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r make call Signed-off-by: Richard Palethorpe <[email protected]>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think we need to do the same also for cuda @richiejp, or it works there somehow (that I can't really see at the moment)? |
|
isn't going to break cflags for llama.cpp? |
|
I can't see right now, hopefully the tests will pass by the time I get chance to look |
|
nevermind, just checked and seems we don't use these down the line in llama.cpp, so I guess it's only the nvidia ldflags here: Line 129 in 4f239ba |
|
but we can test that easily in demo.localai.io, moving on |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Palethorpe [email protected]
Description
THIS TIME!
Notes for Reviewers
Signed commits