Strip -rpath arguments since lld does not support them, but gcc-mingw does #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We shouldn't be doing this in the wrapper; if we want to ignore it, it should be done upstream in LLD. Let's keep the discussion in #300, which I can take further upstream when we have references to where it's needed. |
|
Fair enough. In case this does move forward though, the patch needs to adjusted to deal with quoted arguments. An attempt to deal with that is the third commit to this pull branch. |
|
FWIW, this shouldn't be necessary in the latest prereleases with LLVM 19.x, where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300.