Skip to content

avoid using typescript-specific language extensions (const enum) #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

gfx
Copy link
Member

@gfx gfx commented Nov 6, 2022

Rationale: https://github.com/tc39/proposal-type-annotations#omitted-typescript-specific-features-that-generate-code

The tc39/proposal-type-annotations is considered a minimum viable subset of the TypeScript language. It would be nicer if TypeScript libraries can follow the spec so that any TypeScript processors can compile them.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Base: 98.13% // Head: 98.14% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7966865) compared to base (b015e94).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   98.13%   98.14%           
=======================================
  Files          16       16           
  Lines         966      969    +3     
  Branches      206      206           
=======================================
+ Hits          948      951    +3     
  Misses         18       18           
Impacted Files Coverage Δ
src/Decoder.ts 99.16% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gfx gfx merged commit 11f95f1 into main Nov 6, 2022
@gfx gfx deleted the gfx/avoid-using-typescript-specific-langauge-ext branch November 6, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants