Check process.env exists #199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some build systems or other sometimes add `window.process` in browser but not always add `window.process.env`. For example, a project created with Nuxt3 will crash due to this problem. Please check `process.env` exists or not.
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 16 16
Lines 964 964
Branches 206 206
=======================================
Hits 946 946
Misses 18 18
Continue to review full report at Codecov.
|
|
Thank you for the PR. It sounds almost good to me, but I rather prefer to use the latest syntax for null checking: #200 can you take a look at it? |
|
No problem at all. I'll close this PR. |
|
Thank you! |
|
v2.7.2 has been released with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build systems or other sometimes add
window.processin browser but not always addwindow.process.env.For example, a project created with Nuxt3 will crash due to this problem.
Please check
process.envexists or not.