Various tweaks: #551
Merged
Various tweaks: #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
+ Coverage 92.58% 92.62% +0.03%
==========================================
Files 8 8
Lines 634 637 +3
Branches 150 151 +1
==========================================
+ Hits 587 590 +3
Misses 47 47
Continue to review full report at Codecov.
|
* Make options.port a number, after parsing the url * Update some package.json dependencies (bar `ws`, left at 1.x) * Make travis `script` execute `npm run ci` to send codecov results * Add an .editorconfig file * Add nodejs 4.3.2 to the build matrix for AWS Lambda * Add C++11 compatible compiler for extensions
|
Anyone? |
|
I'm currently traveling, I will review this asap. |
|
No rush :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tweaks:
ws, left at 1.x)scriptexecutenpm run cito send codecov resultsMostly fairly innocuous changes, except the first one, which might give some people a little grief, so needs some consideration. The majority/meat of the tests all pass however (one needed adjusting to test the
options.portset by a parsed url against number rather than a string). The port string/number inconsistency is something I noticed when porting the lib/* to TypeScript a while back.I'd like to get that option consistently a number, then move ahead with #547
I added 4.3.2 to the build matrix just as a heads up. If it gets in the way of where people wanna go (e.g. updating ws to 2.x) we can just disable it. In the mean time, having the CI notify of breakages would be handy for AWS Lambda users, which has an ancient version of node, stuck in the past. Tsk Tsk AWS 👎