Add examples of server and client for streamable http transport #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrpr
changed the title
jspahrsummers
approved these changes
Apr 8, 2025
Comment on lines
+98
to
+104
| // After handling the request, if we get a session ID back, store the transport | ||
| await transport.handleRequest(req, res, req.body); | ||
|
|
||
| // Store the transport by session ID for future requests | ||
| if (transport.sessionId) { | ||
| transports[transport.sessionId] = transport; | ||
| } |
There was a problem hiding this comment.
Hmm, there's a race condition here AFAICT. I believe this sequence of events is possible:
- Client sends initialization request to server
- Server handles the request, assigns a session ID, and sends an initialization response
- Before line 102 is reached, the client sends another request
- Server can't find the session matching its ID
This might be something we have to fix in the interfaces we offer—for example, maybe a callback like onsessioncreated or something?
There was a problem hiding this comment.
yep, good point, the session management is still in the follow ups, I'll address it there if that's okay
1 task
|
Does anyone have a Python SDK link where the work might have started? We can't use TypeScript unfortunately :( |
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
add support for Streamable HTTP server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding new features to the transport it's quite useful to have e2e flow to test on. Introducing the examples folder where we can have examples of mcp clients and servers with different features. Adding a very simple example of:
Follow ups