Skip to content

fix: improve misleading warning for progress callback exceptions #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lorenzocesconetto
Copy link

Currently if the progress notification callback throws an exception we get a misleading warning message.
This PR aims to fix it.

Motivation and Context

How Has This Been Tested?

Ran a few tests locally.

Breaking Changes

No breaking changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this!

There are some suggestion would be good to address before merging:

  • please can you add tests
  • replace use of try-except-else to make it consistent in the project

@lorenzocesconetto
Copy link
Author

lorenzocesconetto commented May 23, 2025

Hi @ihrpr thank you for the review. I'll add the tests.

@lorenzocesconetto
Copy link
Author

Hi @ihrpr, ready for another pass!
I've added the unit test and removed the try-except-else as you've requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants