Skip to content

Include server examples folder in pyright check #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/servers/simple-auth/mcp_simple_auth/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@

from mcp_simple_auth.server import main

sys.exit(main())
sys.exit(main()) # type: ignore[call-arg]
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

from .server import main

sys.exit(main())
sys.exit(main()) # type: ignore[call-arg]
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

from .server import main

sys.exit(main())
sys.exit(main()) # type: ignore[call-arg]
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import click
import mcp.types as types
from mcp.server.lowlevel import Server
from pydantic import FileUrl
from pydantic import AnyUrl

SAMPLE_RESOURCES = {
"greeting": "Hello! This is a sample text resource.",
Expand All @@ -26,7 +26,7 @@ def main(port: int, transport: str) -> int:
async def list_resources() -> list[types.Resource]:
return [
types.Resource(
uri=FileUrl(f"file:///{name}.txt"),
uri=AnyUrl(f"file:///{name}.txt"),
name=name,
description=f"A sample text resource named {name}",
mimeType="text/plain",
Expand All @@ -35,7 +35,9 @@ async def list_resources() -> list[types.Resource]:
]

@app.read_resource()
async def read_resource(uri: FileUrl) -> str | bytes:
async def read_resource(uri: AnyUrl) -> str | bytes:
if uri.path is None:
raise ValueError(f"Invalid resource path: {uri}")
name = uri.path.replace(".txt", "").lstrip("/")

if name not in SAMPLE_RESOURCES:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
from .server import main

if __name__ == "__main__":
main()
# Click will handle CLI arguments
import sys

sys.exit(main()) # type: ignore[call-arg]
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .server import main

if __name__ == "__main__":
main()
main() # type: ignore[call-arg]
2 changes: 1 addition & 1 deletion examples/servers/simple-tool/mcp_simple_tool/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

from .server import main

sys.exit(main())
sys.exit(main()) # type: ignore[call-arg]
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Issues = "https://github.com/modelcontextprotocol/python-sdk/issues"
packages = ["src/mcp"]

[tool.pyright]
include = ["src/mcp", "tests"]
include = ["src/mcp", "tests", "examples/servers"]
venvPath = "."
venv = ".venv"
strict = ["src/mcp/**/*.py"]
Expand Down
Loading