use metadata from SessionMessage to propagate related_request_id #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2025
bhosmer-ant
previously approved these changes
May 1, 2025
| session_message.metadata is not None | ||
| and isinstance( | ||
| session_message.metadata, | ||
| ServerMessageMetadata, |
There was a problem hiding this comment.
Might they be passing their own object (say with added fields) that still has a related_request_id? Not sure the SDK as currently implemented would be capable of handling that (without hacking anyway), but flagging in case we want to relax this to a hasattr
There was a problem hiding this comment.
that's actually the reason why typed metadata was introduced, before I was using meta field in the message, which was quite bad
…essage-for-related-request
…essage-for-related-request
dsp-ant
previously approved these changes
May 2, 2025
ihrpr
dismissed stale reviews from dsp-ant and bhosmer-ant
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the way we handle related request IDs in the streamable HTTP transport. Previously, we were adding _meta fields to notification parameters to link notifications to their triggering requests. This approach was fragile and inconsistent
with how other transports handle message metadata.
Changes
metadata
metadata
Note: stacked on top of #590
Improves related request id handling in #553