Skip to content

Force mypy precommit to use all filenames #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

Force mypy precommit to use all filenames #105

merged 3 commits into from
Jan 10, 2025

Conversation

heyitsaamir
Copy link
Collaborator

By default precommit hooks send only staged files to the hook. But mypy needs all files, otherwise it's not making an informed decision.

See python/mypy#13916.

@Copilot Copilot AI review requested due to automatic review settings January 10, 2025 18:08
@heyitsaamir heyitsaamir requested a review from a team as a code owner January 10, 2025 18:08
Copilot
Copilot AI reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@heyitsaamir heyitsaamir merged commit 6471376 into main Jan 10, 2025
4 checks passed
@heyitsaamir heyitsaamir deleted the aamirj/precommitmypy branch January 10, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@corinagum corinagum corinagum approved these changes

@pradeepananth pradeepananth Awaiting requested review from pradeepananth pradeepananth is a code owner automatically assigned from microsoft/atdp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyitsaamir @corinagum