#345 Include option to show completion list after a character is typed #457
Conversation
…r is typed - trigger completion by default when both AutoListMembers and ShowCompletionListAfterCharacterTyped options are selected - adds option to options page
| @@ -725,8 +732,12 @@ out title | |||
| || (ch >= 'a' && ch <= 'z') || (ch >= 'A' && ch <= 'Z') || (ch >= '0' && ch <= '9'); | |||
| } | |||
|
|
|||
| private static bool IsIdentifierFirstChar(char ch) { | |||
| return ch == '_' || (ch >= 'a' && ch <= 'z') || (ch >= 'A' && ch <= 'Z'); | |||
| } | |||
There was a problem hiding this comment.
Do such helper methods not already exist elsewhere in the parser code?
Also, interesting to see this is all ASCII only (not just your code changes, but surrounding code). Does NTVS not handle Unicode chars? (ES5 allows identifierNames as per the Unicode 3 standard - see http://es5.github.io/#x7.6 ).
|
This will be cool to get in, but changes in these areas are really hard to get just right (just ask @paulvanbrenk how many times he had to redo it for TypeScript 😄 ). Let's not check this in in-between the last RC and RTM. |
| @@ -193,6 +193,13 @@ internal sealed class IntellisenseController : IIntellisenseController, IOleComm | |||
| UpdateCurrentParameter(); | |||
| } | |||
| break; | |||
| default: | |||
| if (IsIdentifierFirstChar(ch) && _activeSession == null | |||
There was a problem hiding this comment.
Did you test this when typing in comments, string literals, etc...? I don't see any filtering here on context (e.g. see some of the checks above like on line 169). It's super annoying when the completion list keeps appears when you're typing in places you don't want it (like those just listed). I've seen those bugs before (I may have written a couple of them :-/ )
There was a problem hiding this comment.
Yeah, the other isense code actually blocks that (reverseExpressionParser and VsAnalyzer.) otherwise Ctrl+space would trigger in comments etc.
|
👍 |
ShowCompletionListAfterCharacterTyped options are selected
Fix #345