Skip to content

Add backend external deps in the vendor patch #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Jan 13, 2025

This PR improves the upgrade backends workflow by putting all the files that are modified as part of this workflow in a single patch file.

The new entries in the go.mod file have been placed in their own require block so that the chances of upstream conflicts are minimized.

The fact that the go.mod changes and the vendoring changes are now in the same patch file also makes the patch file buildable (see #1473).

For #1478.

@qmuntal qmuntal requested a review from a user January 13, 2025 13:00
@qmuntal qmuntal requested a review from a team as a code owner January 13, 2025 13:00
@qmuntal qmuntal requested review from dagood, mertakman and gdams January 13, 2025 13:01
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Base automatically changed from dev/qmuntal/symppatch to microsoft/main January 13, 2025 21:28
@qmuntal qmuntal enabled auto-merge (squash) January 14, 2025 07:21
@qmuntal qmuntal merged commit 7ef39ed into microsoft/main Jan 14, 2025
31 checks passed
@gdams gdams deleted the dev/qmuntal/vendorimpr branch January 14, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants