-
Notifications
You must be signed in to change notification settings - Fork 135
Update TestApp and DemoApp to RN v0.57 #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try removing workaround in android build.gradle and check it builds on AppCenter (release type) with tab icons for Android.
- best practice to ensure consistent npm depedency resolution
CHANGELOG.md
Outdated
@@ -10,6 +10,9 @@ | |||
|
|||
- Fix consuming the SDK as pod dependencies for non standard projects not using react-native link [#326](https://github.com/Microsoft/AppCenter-SDK-React-Native/pull/326). | |||
|
|||
### Misc | |||
|
|||
- SDK supports react-native v0.57.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous version too, since SDK does not require a change I would not document that?
npm install
warnings are no longer there in TestApp and DemoApp. (See RN v0.57 upgrade documentation):