Skip to content

Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags #36947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Feb 21, 2020

...to save space (and possibly to reduce de-opts, since it appears to be lazily set).

...to save space (and possibly to reduce de-opts, since it appears to be
lazily set).
@amcasey
Copy link
Member Author

amcasey commented Feb 21, 2020

Modelled on #36622.

@amcasey
Copy link
Member Author

amcasey commented Feb 21, 2020

This seems unlikely to affect the perf tests, since it mostly applies to intersection and union types, which are not represented in the perf suite.

@amcasey
Copy link
Member Author

amcasey commented Feb 21, 2020

Ugh, muscle memory...
@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 21, 2020

Heya @amcasey, I've started to run the perf test suite on this PR at 2e9972d. You can monitor the build here. It should now contribute to this PR's status checks.

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforwardly good to me, and we can always shuffle around the object flags later if need be.

@amcasey amcasey merged commit b5bd38b into microsoft:master Feb 25, 2020
@amcasey amcasey deleted the CouldContainFlag branch February 25, 2020 02:18
@amcasey
Copy link
Member Author

amcasey commented Feb 25, 2020

@weswigham Finders keepers 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants