Fix 10438 - Remove parameters of private methods and constructors in declaration files

[Igorbek]

Fixes #10438

This PR makes these changes in declaration emitting:

• private instance methods to be emitted as private methodName;
• private static methods to be emitted as private static methodName;
• private constructor to be emitted as private constructor();
• if private method or constructor has overloads then only single declaration is emitted
• instance and static members with the same name are not considered overloads

Open questions:

• is it ok to emit private constructors with removed parameters?
  • I think it is ok, since nobody would be able to call it anyway

#myfirsttypescriptpr

[msftclas]

Hi @Igorbek, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[msftclas]

@Igorbek, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

[Igorbek]

Is it going to be reviewed/merged?

[sheetalkamat]

This seems incorrect way of handling it.
You could just check in emitSignatureDeclaration if this is first signature and skip rest for private methods.
Map of name is not needed and if needed you can ask resolver for the question instead.

[Igorbek]

Thank you, I'll change

[Igorbek]

Hmm, writeFunctionDeclaration first writes declaration flags and function name and then calls emitSignatureDeclaration. So it seems here's the proper place for checking.
Do you suggest to add a new question to resolver? Because I didn't find any that matches that need.

[sheetalkamat]

Need change in approach with method declaration emit

[mhegazy]

Thanks for your contribution. This PR has failing CI tests and can not be merged in at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to merge this code in, please open a new PR that has been merged and rebased with the master branch.