Allows passing iterable to Blob and File
#1536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
@microsoft-github-policy-service agree |
saschanaz
suggested changes
Apr 4, 2023
| @@ -3073,7 +3073,7 @@ interface Blob { | |||
|
|
|||
| declare var Blob: { | |||
| prototype: Blob; | |||
| new(blobParts?: BlobPart[], options?: BlobPropertyBag): Blob; | |||
| new(blobParts?: Iterable<BlobPart>, options?: BlobPropertyBag): Blob; | |||
There was a problem hiding this comment.
You cannot do this as the base lib needs to be ES5 compatible. This kind of thing is done in dom.iterable but the constructor can't be extended in the current design. We are blocked here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob: mdn, w3cFile: mdn, w3c