Skip to content

Improvements and cleanup for typing #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 13, 2024
Merged

Conversation

maxfischer2781
Copy link
Owner

@maxfischer2781 maxfischer2781 commented Mar 3, 2024

This PR is for maintenance on typing support.

  • typing bug fixes:
    • ExitStack.push callables now match the proper ... | None instead of just ...
  • improved support for matching callables and their parameter types
    • functools.lru_cache preserves method parameters
  • promote various (...) -> (await) bool arguments to just (...) -> Any since anything is boolean
  • add various missing @overload cases

@maxfischer2781 maxfischer2781 marked this pull request as ready for review March 3, 2024 17:49
@maxfischer2781 maxfischer2781 self-assigned this Mar 3, 2024
@maxfischer2781 maxfischer2781 merged commit 97564b0 into master Mar 13, 2024
@maxfischer2781 maxfischer2781 deleted the maintenance/typing-20240215 branch March 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants