Skip to content

Update openapi core implementation #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Update openapi core implementation #43

merged 1 commit into from
Feb 18, 2024

Conversation

marcelthole
Copy link
Owner

No description provided.

@marcelthole marcelthole force-pushed the update-openapi branch 2 times, most recently from 600b058 to 93e7145 Compare February 18, 2024 11:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6450c04) 99.34% compared to head (93e7145) 99.34%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #43   +/-   ##
=========================================
  Coverage     99.34%   99.34%           
  Complexity       94       94           
=========================================
  Files            17       17           
  Lines           306      306           
=========================================
  Hits            304      304           
  Misses            2        2           
Files Coverage Δ
src/FileHandling/SpecificationFile.php 100.00% <ø> (ø)
src/Merge/ComponentsMerger.php 100.00% <ø> (ø)
src/Merge/PathMerger.php 100.00% <ø> (ø)
src/Merge/ReferenceNormalizer.php 97.82% <100.00%> (ø)
src/Merge/ReferenceResolverResult.php 100.00% <ø> (ø)
src/Merge/SecurityPathMerger.php 92.30% <ø> (ø)
src/Reader/FileReader.php 100.00% <ø> (ø)
src/Reader/OpenApiReaderWrapper.php 100.00% <ø> (ø)
src/Writer/DefinitionWriter.php 100.00% <ø> (ø)

@marcelthole marcelthole merged commit c9fe020 into main Feb 18, 2024
@marcelthole marcelthole deleted the update-openapi branch February 18, 2024 11:49
@marcelthole marcelthole restored the update-openapi branch February 18, 2024 11:49
@marcelthole marcelthole deleted the update-openapi branch February 18, 2024 11:49
@marcelthole marcelthole mentioned this pull request Feb 18, 2024
@JarJak
Copy link

JarJak commented Jun 28, 2024

Hey @marcelthole any reason why you have choosen cebe's fork https://github.com/openapi-php/php-openapi instead of more up-to-date and actively maintained (and probably also most popular) https://github.com/DEVizzent/cebe-php-openapi ?

Thanks for your work!

@marcelthole
Copy link
Owner Author

Hey,
there wasn't a specific reason. I created this fork to get a up to date version of the cebe project and the main idea was to move this project to a more "open" namespace instead of adding a single maintainer again on a project that is used in so many dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants