Merge response and request bodies #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
============================================
+ Coverage 99.31% 99.34% +0.02%
- Complexity 90 94 +4
============================================
Files 17 17
Lines 294 306 +12
============================================
+ Hits 292 304 +12
Misses 2 2
|
marcelthole
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges response and requestBodies from components section.
It is only a top-level merge, so no media-types are merged at this point. I think that would fit most of the cases.
If at some point we might need a media-type merge it would be easily to implement.
I did not add any acceptance tests files because as in the acceptance the references are resolved there would be no benefit of using refs in components section. This would only test the underlying OpenApi library.