Fix print invoice issue #33800

[Kannakiraj123]

Description (*)

1.Fix print invoice no such entity exception
2.Fix print Shipment no such entity exception

Related Pull Requests

1.I added code try catch for no such entity for invoice id.

Fixed Issues (if relevant)

1. Fixes Issue with print invoice #33800

[m2-assistant]

Hi @Kannakiraj123. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Kannakiraj123]

@magento give me test instance

[magento-deployment-service]

Hi @Kannakiraj123. Thank you for your request. I'm working on Magento instance for you.

[Kannakiraj123]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-deployment-service]

Hi @Kannakiraj123, here is your Magento Instance: https://419d6b712a26bf17dd267036c47d78d8.instances.magento-community.engineering
Admin access: https://419d6b712a26bf17dd267036c47d78d8.instances.magento-community.engineering/admin_83d8
Login: 995cca4a
Password: 4fa0bcd42e2a

[Kannakiraj123]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Kannakiraj123]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[bgorski]

@Kannakiraj123 You used the object manager directly, which is a code smell - you're not supposed to do that ever unless you're writing tests using the Integration Test Framework (in which case it's usually the recommended way). I know that direct object manager usage was already there, but adding more of that is extending the technological debt of the project - it's just more code to fix later. One of the issues of using the object manager directly is that this may break the application on read-only environments like Adobe Commerce Cloud.
I'm going to close this PR for now. You'll welcome to create another one, but please keep in mind that it's addressing a P4 issue - and P4 means "no current plan to fix". This mean that the effort you put in fixing the issue may be greatly deferred or even wasted if the plan to fix (once/if there is one) doesn't include merging the PR as it is.
If you do plan to introduce a new PR despite the fact that it may wait a long time for a merge or never be merged, I'll be happy to review it for you.
Despite the fact that I'm closing the issue, the effort you put in your contributions is still greatly appreciated - keep doing the good work you do! Thanks!

[m2-assistant]

Hi @Kannakiraj123, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.