-
Notifications
You must be signed in to change notification settings - Fork 160
Fix Comment block is missing Failure when Attribute is present after the docblock #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Comment block is missing Failure when Attribute is present after the docblock #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @karyna-tsymbal-atwix ! Please see my comment.
Also, please add several different cases with valid and invalid phpdoc to the unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @karyna-tsymbal-atwix
Thank you for your contribution here
Approved ✔️
@sivaschenko thanks for the review! I've added couple test cases, please check. |
@magento import pr to magento-commerce/magento-coding-standard |
@sivaschenko the Pull Request is successfully imported. |
This PR contains changens according to magento/magento2#34679 |
The Warning 'Comment block is missing' is thrown when the attribute is present after the docblock.
example:
In such case our Sniff should ignore the attribute.