AC-1059: Move PHPCompatibility rules from Magento tests #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svera
commented
Nov 15, 2021
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
|
@sivaschenko static tests check OK: https://github.com/magento-commerce/magento2ce/pull/7224 |
eliseacornejo
previously approved these changes
Nov 17, 2021
sivaschenko
previously approved these changes
Nov 18, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the Pull Request is successfully imported. |
svera
dismissed stale reviews from sivaschenko and eliseacornejo
via
168882e
…into AC-1059_move-phpcompatibility-rules-from-magento-tests
sivaschenko
approved these changes
Nov 19, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the Pull Request is successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare PHPCompatibility as a dependency of magento-coding-standard
Include
/dev/tests/static/testsuite/Magento/Test/Php/_files/PHPCompatibilityMagento/ruleset.xmlin theMagento2/ruleset.xml