Added deprecated function PHP 8.1 to DiscouragedFunctionSniff

[anzin]

Description (*)

Added deprecated function PHP 8.1 to DiscouragedFunctionSniff

Addresses backward incompatible change in PHP 8.1: https://wiki.php.net/rfc/deprecations_php_8_1

Fixed Issues (if relevant)

1. Add functions to sniff Magento2.Functions.DiscouragedFunction of the magento-coding-standard magento2#34548

Contribution checklist (*)

• Author has signed the Adobe CLA
• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[sivaschenko]

Thanks for the pull request @anzin ! Please see my comment

[sivaschenko]

It would be great to add replacement recommendations for each of the deprecated functions. For example for this function:

Suggested change

	'^strftime$' => null,
	'^strftime$' => 'IntlDateFormatter::format()',

[sivaschenko]

Even though the replacement can be more complex than just a single function call, like in this case

setlocale(LC_ALL, 'nl_NL');
$formatter = new IntlDateFormatter(\Locale::getDefault(), IntlDateFormatter::FULL, IntlDateFormatter::FULL);
$formatter->setPattern('EEEE, LLLL d');
echo $formatter->format(new DateTime());

I think the replacement suggestion should at least help the developer with the research direction.

[anzin]

Hello @sivaschenko, I added some replacement recommendations, please check if every.

[sivaschenko]

@magento import pr to magento-commerce/magento-coding-standard

[m2-github-services]

@sivaschenko an error occurred during the Pull Request import.