Add Sniff for check autovivification on array #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbess
previously approved these changes
Nov 2, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
Thank you for the valuable contribution @anzin ! Can you please add the unit test for this sniff. Having the test code will make it much easier to review the PR. |
loginesta
previously approved these changes
Nov 2, 2021
andrewbess
approved these changes
Nov 2, 2021
ihor-sviziev
approved these changes
Nov 3, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko an error occurred during the Pull Request import. |
loginesta
approved these changes
Nov 3, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@svera an error occurred during the Pull Request import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added sniff for check autovivification on array.
Addresses backward incompatible change in PHP 8.1: https://wiki.php.net/rfc/autovivification_false
Fixed Issues (if relevant)
Magento2.PHP.ArrayAutovivificationinto magento-coding-standard magento2#34509Contribution checklist (*)