Skip to content

Extracted js tests to a separate build in github actions #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions .github/workflows/php.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ on:
branches: [ master, develop ]

jobs:
build:

php:
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -41,10 +40,6 @@ jobs:

- name: Install dependencies
run: npm install
- name: Run ESLint
run: npm run eslint -- eslint/rules
- name: Run JSCS
run: npm run jscs eslint/rules Magento2

- name: Validate composer
run: composer validate
Expand All @@ -63,3 +58,23 @@ jobs:

- name: Run framework suite
run: vendor/bin/phpcs --standard=Magento2Framework Magento2/Helpers Magento2/Sniffs Magento2Framework/Sniffs
js:
runs-on: ubuntu-latest
name: Javascript tests

steps:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '16'

- uses: actions/checkout@v2

- name: Install dependencies
run: npm install

- name: Run ESLint
run: npm run eslint -- eslint/rules

- name: Run JSCS
run: npm run jscs eslint/rules Magento2