AC-206: Create UCT phpcs ruleset for customizations only #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcuerdo
previously approved these changes
Oct 14, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
loginesta
previously approved these changes
Oct 18, 2021
…standard into AC-206_customizations_ruleset
…standard into AC-206_customizations_ruleset
svera
commented
Oct 19, 2021
| @@ -37,7 +37,8 @@ class RestrictedCodeSniff implements Sniff | |||
| */ | |||
| public function __construct() | |||
| { | |||
| $this->loadData('restricted_classes*.php'); | |||
There was a problem hiding this comment.
I did create this method exactly to avoid the warning thrown by PHPCS about using include. But I guess it is OK to break our own rules sometimes :)
There was a problem hiding this comment.
@svera the warning about include was skipped using phpcs:ignore (that is preserved, but the actual rule that needs to be skipped is specified after refactoring)
|
It is my own PR so I cannot approve it |
loginesta
approved these changes
Oct 19, 2021
sivaschenko
approved these changes
Oct 20, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko an error occurred during the Pull Request import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new standard
Magento2Frameworkand corresponding namespace containing tests applicable only for the framework testing are introduced.The rules extracted to the new standard: