AC-672: Create phpcs static check for LicenseTest #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loginesta
previously approved these changes
Oct 14, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
sivaschenko
reviewed
Oct 14, 2021
Magento2/ruleset.xml
Outdated
| @@ -194,6 +194,10 @@ | |||
| <type>warning</type> | |||
| <exclude-pattern>*\.xml$</exclude-pattern> | |||
| </rule> | |||
| <rule ref="Magento2.Legacy.License"> | |||
| <severity>9</severity> | |||
There was a problem hiding this comment.
I'd move it to Magento specific (warning 8)
jcuerdo
previously approved these changes
Oct 14, 2021
jcuerdo
previously approved these changes
Oct 14, 2021
| if (stripos($commentContent, 'copyright') === false) { | ||
| return; | ||
| } | ||
| foreach (['Irubin Consulting Inc', 'DBA Varien', 'Magento Inc'] as $legacyText) { |
There was a problem hiding this comment.
I'd move the array to a constant.
jcuerdo
approved these changes
Oct 14, 2021
loginesta
approved these changes
Oct 14, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@eliseacornejo the Pull Request is successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.