AC-683: Create phpcs static check for TableTest #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loginesta
reviewed
Oct 6, 2021
| /*3 => 1, | ||
| 7 => 1, | ||
| 14 => 1, | ||
| 28 => 1,*/ |
There was a problem hiding this comment.
tests are failing, I guess you need to update this list:
1) Magento2\Tests\Legacy\TableNameUnitTest::testSniff
[LINE 3] Expected 0 error(s) in TableNameUnitTest.inc but found 1 error(s). The error(s) found were:
-> Legacy table names with slash must be fixed to direct table names. Found: '/catalog_category_product' (Magento2.Legacy.TableName.FoundLegacyTableName)
[LINE 7] Expected 0 error(s) in TableNameUnitTest.inc but found 1 error(s). The error(s) found were:
-> Legacy table names with slash must be fixed to direct table names. Found: '/cataloginventory_stock_item' (Magento2.Legacy.TableName.FoundLegacyTableName)
[LINE 16] Expected 0 error(s) in TableNameUnitTest.inc but found 1 error(s). The error(s) found were:
-> Legacy table names with slash must be fixed to direct table names. Found: '/is_in_stock' (Magento2.Legacy.TableName.FoundLegacyTableName)
[LINE 20] Expected 0 error(s) in TableNameUnitTest.inc but found 1 error(s). The error(s) found were:
-> Legacy table names with slash must be fixed to direct table names. Found: 'magento/sample_table' (Magento2.Legacy.TableName.FoundLegacyTableName)
[LINE 38] Expected 0 error(s) in TableNameUnitTest.inc but found 1 error(s). The error(s) found were:
-> Legacy table names with slash must be fixed to direct table names. Found: 'magento/sales_order_aggregated_updated' (Magento2.Legacy.TableName.FoundLegacyTableName)
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
loginesta
previously approved these changes
Oct 6, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@svera the Pull Request is successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that references to table names in arrays, method calls and property
$_aggregationTabledoes not contain/