Skip to content

AC-1128: Add severity and type (warning or error) for annotation, htm… #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2021
Merged

AC-1128: Add severity and type (warning or error) for annotation, htm… #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions Magento2/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@
<severity>9</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.Html.HtmlBinding">
<severity>9</severity>
<type>warning</type>
</rule>

<!-- Severity 8 warnings: Magento specific code issues and design violations. -->
<rule ref="Magento2.Classes.AbstractApi">
Expand Down Expand Up @@ -233,6 +237,10 @@
<severity>8</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.Html.HtmlDirective">
<severity>8</severity>
<type>warning</type>
</rule>

<!-- Severity 7 warnings: General code issues. -->
<rule ref="Generic.Arrays.DisallowLongArraySyntax">
Expand Down Expand Up @@ -565,6 +573,15 @@
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Squiz.CSS.NamedColours">
<severity>6</severity>
<type>warning</type>
</rule>
<rule ref="Magento2.Less">
<severity>6</severity>
<type>warning</type>
<include-pattern>*\.less$</include-pattern>
</rule>
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.StartFile">
<severity>0</severity>
</rule>
Expand Down Expand Up @@ -596,16 +613,13 @@
<type>warning</type>
</rule>
<rule ref="Magento2.Annotation">
<severity>5</severity>
<type>warning</type>
<exclude-pattern>*/_files/*</exclude-pattern>
<exclude-pattern>*/Test/*</exclude-pattern>
<exclude-pattern>*Test.php</exclude-pattern>
</rule>
<rule ref="Magento2.Html"/>
<rule ref="Magento2.Less">
<include-pattern>*\.less$</include-pattern>
</rule>
<rule ref="Internal.NoCodeFound">
<severity>0</severity>
</rule>
<rule ref="Squiz.CSS.NamedColours"/>
</ruleset>