Skip to content

chore: allow plotly.js@2 #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022
Merged

chore: allow plotly.js@2 #2711

merged 1 commit into from
Mar 29, 2022

Conversation

zettca
Copy link
Member

@zettca zettca commented Mar 29, 2022

Allows an app to use plotly.js v1 or v2, which fixes #2710.

Testing if internal bump to plotly.js@2 breaks. It seems like the breaking changes mightdo not affect UI-Kit's charts.

Does it make sense to make this bump in a patch/minor?

Looking forward, given:

  • that plotly still relies heavily on window.document
  • that plotly is a large library
  • how often the charts are used
  • that in Design System they're in a separate "visualisation" component library
    it might be worth it to look into splitting the Visualisation components into a separate library

@github-actions github-actions bot temporarily deployed to uikit/pr-2711 March 29, 2022 00:44 Inactive
@zettca zettca requested review from nantunes, diogofscmariano and a team March 29, 2022 09:09
@francisco-guilherme
Copy link
Contributor

Hi @zettca , it makes a lot of sense to do this update 👍
We just need to reinsure that it doesn't affect the UI Kit.
We are also planning on moving the visualisations to their own package on the next major.

@zettca zettca marked this pull request as ready for review March 29, 2022 10:23
@eliofreitas eliofreitas merged commit b0638bf into master Mar 29, 2022
@eliofreitas eliofreitas deleted the zettca/plotly2 branch March 29, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotly breaks UI-Kit in SSG and ES6 modules imports
3 participants