Skip to content

[SelectionDAG] Use the nuw flag when expanding loads. #119288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[SelectionDAG] Use the nuw flag when expanding loads. #119288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff2a597
[SelectionDAG] Use the nuw flag when expanding loads.
sunfishcode Dec 9, 2024
ce3717b
Update CodeGen/AMDGPU/buffer-intrinsics-mmo-offsets.ll.
sunfishcode Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/CodeGen/SelectionDAG/LegalizeTypesGeneric.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ void DAGTypeLegalizer::ExpandRes_NormalLoad(SDNode *N, SDValue &Lo,

// Increment the pointer to the other half.
unsigned IncrementSize = NVT.getSizeInBits() / 8;
Ptr = DAG.getMemBasePlusOffset(Ptr, TypeSize::getFixed(IncrementSize), dl);
Ptr = DAG.getObjectPtrOffset(dl, Ptr, TypeSize::getFixed(IncrementSize));
Hi = DAG.getLoad(
NVT, dl, Chain, Ptr, LD->getPointerInfo().getWithOffset(IncrementSize),
LD->getOriginalAlign(), LD->getMemOperand()->getFlags(), AAInfo);
Expand Down
291 changes: 144 additions & 147 deletions llvm/test/CodeGen/AMDGPU/buffer-intrinsics-mmo-offsets.ll
View file
Open in desktop

Large diffs are not rendered by default.

60 changes: 15 additions & 45 deletions llvm/test/CodeGen/WebAssembly/fpclamptosat.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,7 @@ define i64 @utest_f64i64(double %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixunsdfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -563,9 +561,7 @@ define i64 @utest_f64i64_cse_combine(double %x) #0 {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixunsdfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -602,9 +598,7 @@ define i64 @ustest_f64i64(double %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixdfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -661,9 +655,7 @@ define i64 @ustest_f64i64_cse_combine(double %x) #0 {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixdfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -727,9 +719,7 @@ define i64 @utest_f32i64(float %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixunssfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -781,9 +771,7 @@ define i64 @ustest_f32i64(float %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixsfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -840,9 +828,7 @@ define i64 @ustest_f32i64_cse_combine(float %x) #0 {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixsfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -910,9 +896,7 @@ define i64 @utesth_f16i64(half %x) {
; CHECK-NEXT: call __extendhfsf2
; CHECK-NEXT: call __fixunssfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -981,9 +965,7 @@ define i64 @ustest_f16i64(half %x) {
; CHECK-NEXT: call __extendhfsf2
; CHECK-NEXT: call __fixsfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -1471,9 +1453,7 @@ define i64 @utest_f64i64_mm(double %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixunsdfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -1509,9 +1489,7 @@ define i64 @ustest_f64i64_mm(double %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixdfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -1573,9 +1551,7 @@ define i64 @utest_f32i64_mm(float %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixunssfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -1611,9 +1587,7 @@ define i64 @ustest_f32i64_mm(float %x) {
; CHECK-NEXT: local.get 0
; CHECK-NEXT: call __fixsfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -1679,9 +1653,7 @@ define i64 @utesth_f16i64_mm(half %x) {
; CHECK-NEXT: call __extendhfsf2
; CHECK-NEXT: call __fixunssfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down Expand Up @@ -1719,9 +1691,7 @@ define i64 @ustest_f16i64_mm(half %x) {
; CHECK-NEXT: call __extendhfsf2
; CHECK-NEXT: call __fixsfti
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.const 8
; CHECK-NEXT: i32.add
; CHECK-NEXT: i64.load 0
; CHECK-NEXT: i64.load 8
; CHECK-NEXT: local.set 2
; CHECK-NEXT: local.get 1
; CHECK-NEXT: i64.load 0
Expand Down
Loading
Loading